Fix thread safety issue in HTTP exporters

open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift

https://opentelemetry.io/docs/instrumentation/swift/

Apache License 2.0

221 stars 145 forks source link

Fix thread safety issue in HTTP exporters #481

Closed justinhporter closed 10 months ago

justinhporter commented 1 year ago

We were seeing occasional crashes that were caused by pendingLogRecords being accessed from multiple threads. After making these changes, the crashes went away.

linux-foundation-easycla[bot] commented 1 year ago

:white_check_mark: login: nachoBonafonte / name: Ignacio Bonafonte (d615964f02cbb3c4d73240809d7e39c2309c7b4b)
:x: - login: @justinhporter / name: Justin Porter . The commit (409f18b0677f9813a419f2292ff83849ed3318c9, 33e1771d13d0e24935e3bf517a8f1980bc9b7e5b, e19442aad211b835084ed61d1e07c054e6f05b23) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
...penTelemetryProtocolCommon/trace/SpanAdapter.swift	`99.00% <100.00%> (ø)`
...etryProtocolGrpc/trace/OtlpTraceJsonExporter.swift	`88.57% <100.00%> (ø)`
...lemetryProtocolHttp/logs/OtlpHttpLogExporter.swift	`67.64% <100.00%> (+4.93%)`	:arrow_up:
...ryProtocolHttp/metric/OltpHTTPMetricExporter.swift	`66.12% <100.00%> (+6.51%)`	:arrow_up:
...ocolHttp/metric/StableOtlpHTTPMetricExporter.swift	`73.33% <100.00%> (+4.10%)`	:arrow_up:
...etryProtocolHttp/trace/OtlpHttpTraceExporter.swift	`60.00% <100.00%> (+6.66%)`	:arrow_up:
...ers/OpenTelemetryProtocolHttp/Internal/Locks.swift	`40.00% <40.00%> (ø)`

:loudspeaker: Thoughts on this report? Let us know!.

nachoBonafonte commented 1 year ago

You will have to sign the easyCLA before the PR can be merged.

nachoBonafonte commented 1 year ago

Any updates about the CLA @justinhporter ?

justinhporter commented 1 year ago

Any updates about the CLA @justinhporter ?

We're working on getting it signed.

nachoBonafonte commented 11 months ago

Any updates @justinhporter ?

justinhporter commented 11 months ago

Any updates @justinhporter ?

Sorry, it's taking longer than I expected to get sign off from our legal department. People are out this week, but I'll try again after Thanksgiving.

bryce-b commented 11 months ago

@justinhporter any progress on getting the CLA signed? If you can't get it done soon, we'll have to recreate the pr to get this fixed.

justinhporter commented 11 months ago

@justinhporter any progress on getting the CLA signed? If you can't get it done soon, we'll have to recreate the pr to get this fixed.

Still trying, but at this point feel free to recreate this PR.