search

open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
209 stars 129 forks source link

Fix system version comparison in iOS and watchOS #487

Closed nachoBonafonte closed 9 months ago

nachoBonafonte commented 9 months ago

Fix system version comparison in iOS and watchOS. It was failing when version included more than two numbers.

Fixes #483

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a7426e4) 66.51% compared to head (a27508d) 66.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #487 +/- ## ========================================== - Coverage 66.51% 66.47% -0.05% ========================================== Files 335 335 Lines 14327 14325 -2 ========================================== - Hits 9530 9522 -8 - Misses 4797 4803 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nachoBonafonte commented 9 months ago

This solution is wrong, don't merge