search

open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
209 stars 129 forks source link

Fixed removeContextValue function and added a Test testRemoveContextValuesFromSpan for it #498

Closed vvydier closed 8 months ago

vvydier commented 8 months ago

I tested this with a span and added it to 2 parent spans in different threads. Total of 5 contexts getting removed in this case. Tested with a crude mechanism (using sleep) for now. Will improve it with a Semaphore or async/await later.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c292d46) 66.34% compared to head (57249c7) 66.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #498 +/- ## ========================================== - Coverage 66.34% 66.34% -0.01% ========================================== Files 336 336 Lines 14408 14406 -2 ========================================== - Hits 9559 9557 -2 Misses 4849 4849 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.