search

open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
219 stars 140 forks source link

Expands LogRecord to allow "anyValue" in body parameter. #499

Closed bryce-b closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e1c6468) 66.33% compared to head (36f4dcf) 66.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #499 +/- ## ========================================== + Coverage 66.33% 66.42% +0.09% ========================================== Files 336 336 Lines 14406 14446 +40 ========================================== + Hits 9556 9596 +40 Misses 4850 4850 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vvydier commented 10 months ago

That looks like the right way to do it! I created the spec-change branch after I modified the ActivityContextManager code and test case in my main, so it also shows up here. Do you think it would be ok to merge this or do we need to remove the ActivityContextManager updates from this PR?