Closed jhoongo closed 5 months ago
Attention: Patch coverage is 90.38462%
with 55 lines
in your changes are missing coverage. Please review.
Project coverage is 68.41%. Comparing base (
1535a05
) to head (f69c8b2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Really great work, just some minor stylistic issues.
Thanks for the review @nachoBonafonte ! I've updated the PR with your feedback and rebase it to the latest main. Please let me know if you still have any further feedback or concern. Thanks,
This PR implements
ExponentialHistogram
metric in Swift SDK. Most of the implementations was inspired and driven by https://github.com/open-telemetry/opentelemetry-java SDK. It has been validated with Java SDK to ensure that it generates the same results and passes the same tests for the most part.There might be some missing area that I might have missed on this, but this should be good enough for us to starting point for supporting Exponential Histogram.
I have excluded the implementation of Exponential Histogram on the old metric and only implemented it for Stable Metrics.
Note: I just notice the spacing/indentation issue on this PR, will follow up shortly on this.Fixed the indentation issues and added few more testings