open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
207 stars 124 forks source link

Adds a way to generate XCFramework that can be used for releases #528

Open tapthaker opened 4 months ago

tapthaker commented 4 months ago

I am not aware of all the packages that should be generated for releases. We needed OpenTelemetryApi, but it should be easy to extend it for other packages.

linux-foundation-easycla[bot] commented 4 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

heckj commented 4 months ago

Just a head's up - if you want to use an XCFramework in an app deliverable through the App Store, Apple will require that it is both signed and includes a privacy manifest.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.45%. Comparing base (34c4569) to head (683b387).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #528 +/- ## ========================================== + Coverage 68.41% 68.45% +0.03% ========================================== Files 344 344 Lines 15151 15151 ========================================== + Hits 10365 10371 +6 + Misses 4786 4780 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nachoBonafonte commented 4 months ago

We think it is a great start, but to be really useful for the project we would need it to allow selecting which targets of the project to include and also to be able to select the platforms/destinations to build for. Then it would be a great tool for any user. With the functionality as is the audience for this change is too narrow. Would you mind expanding it?

nachoBonafonte commented 3 months ago

Hi @tapthaker, are you interested in improving the PR with the needs exposed?

tapthaker commented 3 months ago

I missed your previous comment. Yes I am interested in modifying this PR. I'll get back to you

n-ravichandran commented 2 weeks ago

@tapthaker Does this approach work for packages with external dependencies or resources, like the exporters that depend on swift-protofbuf and swift-nio?