Open tapthaker opened 4 months ago
Just a head's up - if you want to use an XCFramework in an app deliverable through the App Store, Apple will require that it is both signed and includes a privacy manifest.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.45%. Comparing base (
34c4569
) to head (683b387
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We think it is a great start, but to be really useful for the project we would need it to allow selecting which targets of the project to include and also to be able to select the platforms/destinations to build for. Then it would be a great tool for any user. With the functionality as is the audience for this change is too narrow. Would you mind expanding it?
Hi @tapthaker, are you interested in improving the PR with the needs exposed?
I missed your previous comment. Yes I am interested in modifying this PR. I'll get back to you
@tapthaker Does this approach work for packages with external dependencies or resources, like the exporters that depend on swift-protofbuf
and swift-nio
?
I am not aware of all the packages that should be generated for releases. We needed
OpenTelemetryApi
, but it should be easy to extend it for other packages.