Closed khushijain21 closed 1 month ago
Hello Reviewers, can you please take a look at the approach? Your feedback is appreciated. Thanks @nachoBonafonte @bryce-b @vvydier
Attention: Patch coverage is 64.00000%
with 72 lines
in your changes missing coverage. Please review.
Project coverage is 68.17%. Comparing base (
34c4569
) to head (ad2b739
). Report is 8 commits behind head on main.:exclamation: Current head ad2b739 differs from pull request most recent head 5b372c3
Please upload reports for the commit 5b372c3 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sorry, was not able to work on this again. There is just one thing - the bridge may not want to depend on the OpenTelemetrySDK
closing PR due to contamination of upstream repo. I'll reopen with another branch.
@khushijain21 I removed the dependency on the SDK in the new PR
Logging Bridge for Apple's SwiftLog https://github.com/open-telemetry/opentelemetry-swift/issues/517
Some Notes: Basic Structure - LogHandler implements
TODO: Write tests for the bridge