open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
207 stars 124 forks source link

[WIP] Bridge: Logging Bridge for SwiftLog #535

Closed khushijain21 closed 1 month ago

khushijain21 commented 4 months ago

Logging Bridge for Apple's SwiftLog https://github.com/open-telemetry/opentelemetry-swift/issues/517

Some Notes: Basic Structure - LogHandler implements

TODO: Write tests for the bridge

khushijain21 commented 3 months ago

Hello Reviewers, can you please take a look at the approach? Your feedback is appreciated. Thanks @nachoBonafonte @bryce-b @vvydier

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 64.00000% with 72 lines in your changes missing coverage. Please review.

Project coverage is 68.17%. Comparing base (34c4569) to head (ad2b739). Report is 8 commits behind head on main.

:exclamation: Current head ad2b739 differs from pull request most recent head 5b372c3

Please upload reports for the commit 5b372c3 to get more accurate results.

Files Patch % Lines
Sources/Bridges/OTelSwiftLog/LogHandler.swift 49.54% 55 Missing :warning:
...urces/OpenTelemetryApi/Common/AttributeValue.swift 80.00% 6 Missing :warning:
Sources/Exporters/Jaeger/Adapter.swift 81.48% 5 Missing :warning:
...TelemetryProtocolCommon/common/CommonAdapter.swift 62.50% 3 Missing :warning:
...urces/OpenTelemetryApi/Common/AttributeArray.swift 80.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #535 +/- ## ========================================== - Coverage 68.41% 68.17% -0.24% ========================================== Files 344 346 +2 Lines 15151 15240 +89 ========================================== + Hits 10365 10390 +25 - Misses 4786 4850 +64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

khushijain21 commented 1 month ago

Sorry, was not able to work on this again. There is just one thing - the bridge may not want to depend on the OpenTelemetrySDK

bryce-b commented 1 month ago

closing PR due to contamination of upstream repo. I'll reopen with another branch.

bryce-b commented 1 month ago

@khushijain21 I removed the dependency on the SDK in the new PR