Closed mamunto closed 1 month ago
Yes, you are true, it was an oversight and there is indeed a potential crash. If "get" cannot run concurrently is better to use serial queue with sync, as is basically what is doing it now using barrier in both. Would you mind doing that change instead?
Yes, you are true, it was an oversight and there is indeed a potential crash. If "get" cannot run concurrently is better to use serial queue with sync, as is basically what is doing it now using barrier in both. Would you mind doing that change instead?
Yes, I can do but wanted some feedback from the team incase there is any other thoughts. Will push the change.
That looks perfect, thanks a lot
Please let me know when we can get this PR merge and possibly a release
Inside
getAggregatorHandle
function we are just not doing read, there is a write as well. Here is code that's doing write operation:Concurrency queue could be overkill here, better to use a serial queue with sync or async (we will need more code changes for return) is much better option.