open-telemetry / opentelemetry.io

The OpenTelemetry website and documentation
https://opentelemetry.io
Creative Commons Attribution 4.0 International
512 stars 1.09k forks source link

Opinionated baggage advice #3832

Open austinlparker opened 7 months ago

austinlparker commented 7 months ago

Capturing some conversations I've had on baggage leaking attributes between OTel users --

These would be useful extensions to the baggage concept page

svrnm commented 7 months ago

Thanks for capturing this, I had heard some of that in the past as well. I like the idea to have some opinionated advice, this is what people are looking for at the end.

Odd question, what about applying encryption on the baggage? if only "my" otel users know the key to decrypt, this becomes a much smaller problem (also you send a lot of garbage over the wire)

austinlparker commented 7 months ago

eh, i could maybe see encrypting it before it goes out but it's still extra work (also, if you try to encrypt between services then you have to deal with shared secrets and whatever)

svrnm commented 7 months ago

eh, i could maybe see encrypting it before it goes out but it's still extra work (also, if you try to encrypt between services then you have to deal with shared secrets and whatever)

yeah, it's not a very practical solution, I was just wondering about it (a little bit off topic I guess)

theletterf commented 7 months ago

I'm assuming those best practices are knowledge the Collector maintainers could provide, right? Could we ask them?

svrnm commented 7 months ago

I'm assuming those best practices are knowledge the Collector maintainers could provide, right? Could we ask them?

baggage is probably one of the few topics the collector has no relationship with, since it is purely for propagating data among services. The SDK SIGs might have some ideas around it, but I would say this is especially a practitioner topic, so people who use and implement otel in their day to day job should be the SMEs here.