[i18n] Ensure section-local image paths fall back to default lang image

open-telemetry / opentelemetry.io

The OpenTelemetry website and documentation

https://opentelemetry.io

Creative Commons Attribution 4.0 International

522 stars 1.12k forks source link

[i18n] Ensure section-local image paths fall back to default lang image #4761

Closed chalin closed 2 months ago

chalin commented 3 months ago

_Originally posted by @chalin in https://github.com/open-telemetry/opentelemetry.io/pull/4741#discussion_r1657789446_

Hugo is now setup to reuse the default language image -- the exact same file, no duplication (as was the case for static resources a few Hugo versions ago).

Images should not be duplicated. I'd suggest using the default image except where there's too much English text in the image, of course.

chalin commented 3 months ago

Actually, it just works (as I expected originally, but was confused by the ja PR that included an image override). Will keep this open for a little while longer; maybe until I at least add a comment to the i18n docs.