search

open-telemetry / opentelemetry.io

The OpenTelemetry website and documentation
https://opentelemetry.io
Creative Commons Attribution 4.0 International
514 stars 1.1k forks source link

Python zero-code instrumentation does not use bytecode injection #5089

Closed aabmass closed 1 week ago

aabmass commented 3 weeks ago

https://opentelemetry.io/docs/zero-code/python/

The intro paragraph says

It dynamically injects bytecode to capture telemetry from many popular libraries and frameworks.

But this is not accurate. We use monkey patching in almost all cases.

cartermp commented 3 weeks ago

Huh, I had thought maybe this was some shared text but it seems this was only written for the Python docs. Yeah, this should change.

CFly17 commented 2 weeks ago

Hi @aabmass! Feel free to assign to me, I'm happy to contribute and update this documentation. Thanks for pointing this out.

cartermp commented 1 week ago

@CFly17 we don't assign issues in this repo, but feel free to just send a PR and we'll gladly review it.

CFly17 commented 1 week ago

Thanks @cartermp. This is my first contribution to open source. https://github.com/open-telemetry/opentelemetry.io/pull/5130

CFly17 commented 1 week ago

attempting to fix failed checks for

After pushing what I believe to be the fixes, I proceeded to sync with main and the checks stopped. I believe I need workflow approval from a maintainer now.

svrnm commented 1 week ago

is this fixed via #5130?

CFly17 commented 1 week ago

Yes @svrnm. But my merged PR left behind an unused refcache link. If the code was already merged, should I push to the same branch, or open a new PR to remove this line?

svrnm commented 1 week ago

Yes @svrnm. But my merged PR left behind an unused refcache link. If the code was already merged, should I push to the same branch, or open a new PR to remove this line?

I guess we have many of those, so do not worry about it ;-)