open-telemetry / opentelemetry.io

The OpenTelemetry website and documentation
https://opentelemetry.io
Creative Commons Attribution 4.0 International
536 stars 1.18k forks source link

OTLP Exporter Configuration - missing some metrics environment variables #5095

Open aabmass opened 2 months ago

aabmass commented 2 months ago

https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ documents OTLP environment variables but is missing the variables from the Metrics SDK spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md

theletterf commented 2 months ago

+CC @open-telemetry/collector-approvers

mx-psi commented 2 months ago

@theletterf I think you meant to ping a different handle? I don't think this has to do with the Collector

theletterf commented 2 months ago

@mx-psi You're right! Would spec-semconv be the most appropriate here, @svrnm ?

svrnm commented 1 month ago

I would say @open-telemetry/spec-sponsors ?

cijothomas commented 1 month ago

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

(Separately, https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ is missing a mention that, depending on the language, some env variables may/may not be supported. And even if they are supported, some languages may treat ENV variables as lower priority than in-code configurations.)

cartermp commented 1 month ago

The general thinking behind this page (when I first wrote it, that is) is that it documents some of the most-used env vars. But it hasn't really changed since then, and this was before metrics stabilized. So I'm in favor of just adding these.

svrnm commented 1 month ago

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

From my point of view, Spec sponsors like other approvers&maintainers are doc owners

cijothomas commented 1 month ago

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

From my point of view, Spec sponsors like other approvers&maintainers are doc owners

I see. Sorry I wasn't seeing it that way. I assumed that docs are owned by docs team and content is sourced from the spec repo. I think Spec sponsors' responsibility is to make any changes/clarifications to the spec itself. Since this issue is simply missing some configuration in the docs page, I was wondering, what help is needed from spec-sponsors. Doc owners can just make the change to the doc.

(I am not opposed to making spec-sponsors as doc owners. Its best to call it out explicitly if that is the expectation)

svrnm commented 1 month ago

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

From my point of view, Spec sponsors like other approvers&maintainers are doc owners

I see. Sorry I wasn't seeing it that way. I assumed that docs are owned by docs team and content is sourced from the spec repo. I think Spec sponsors' responsibility is to make any changes/clarifications to the spec itself. Since this issue is simply missing some configuration in the docs page, I was wondering, what help is needed from spec-sponsors. Doc owners can just make the change to the doc.

(I am not opposed to making spec-sponsors as doc owners. Its best to call it out explicitly if that is the expectation)

Yeah, my assumption here was implicit, we might want to clarify that, but that's a separate issue, not related to this discussion.

cijothomas commented 1 month ago

Yes that is separately clarifiable. For this issue, I support what Carter suggested: https://github.com/open-telemetry/opentelemetry.io/issues/5095#issuecomment-2331539329 but it'd be good to call out that ENV vars are optional and languages may/may not have it to avoid surprises. (I believe this was also reported by some users in the past, but I cannot find the tracking issue now.)

cijothomas commented 1 month ago

related : https://github.com/open-telemetry/opentelemetry-specification/issues/3929

cijothomas commented 1 month ago

https://github.com/open-telemetry/opentelemetry.io/pull/4099/files can be extended to cover this page as well https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ to close my concern!