search

open-telemetry / opentelemetry.io

The OpenTelemetry website and documentation
https://opentelemetry.io
Creative Commons Attribution 4.0 International
520 stars 1.11k forks source link

Page feedback - feature flags #5154

Closed szeitlin closed 3 weeks ago

szeitlin commented 3 weeks ago

Suggested improvements for page: https://opentelemetry.io/docs/demo/feature-flags/

This looks very straightforward, except the repo I'm using doesn't seem to have a src/flagd/demo.flagd.json file.

All I see in the src folder is the services, there is no flagd folder.

tiffany76 commented 3 weeks ago

Thanks for reporting your issue, @szeitlin.

@open-telemetry/demo-approvers, PTAL!

julianocosta89 commented 3 weeks ago

@szeitlin which repo are you using? This doc page is responsible for instructions on the upstream OpenTelemetry Demo: https://github.com/open-telemetry/opentelemetry-demo

If you are using a vendor fork or some outdated version of the demo you indeed may not have that file.

In that case you can navigate to the path /feature of your your frontend page. Depending on how you are running the demo, that would be:

http://localhost:8080/feature

The Feature Flags can be enabled/disabled in there.

I don't think we should have that explained in the upstream docs though, as we try to keep docs and demo up-to-date and in sync.

szeitlin commented 3 weeks ago

interesting, I'll try that. Yeah this is a vendor fork (and their fork isn't completely up to date with yours, it turns out). Thanks!

tiffany76 commented 3 weeks ago

Thanks, all!

@szeitlin I'm going to close this issue, but please feel free to come back with any other docs issues you encounter.