open-telemetry / otel-arrow

Protocol and libraries for sending and receiving OpenTelemetry data using Apache Arrow
Apache License 2.0
68 stars 13 forks source link

Avoid work for already-canceled requests #213

Closed jmacd closed 3 months ago

jmacd commented 3 months ago

This is consistent with gRPC behavior for unary exporters, as with for HTTP exporters. It also helps us test with realistic conditions in the new integration test of #210.

https://grpc.io/docs/guides/deadlines/ explains why the default behavior is the way it is for unary gRPC. This is also the case for Golang's net/http client, which is used for the OTLP/HTTP exporter. Therefore, it seems the right thing to do for Arrow as well. Further, if we were to support extending the deadline on purpose, it would belong in the exporterhelper code (IMO).