search

open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
337 stars 164 forks source link

Instrumentation Ecosystem Management #155

Closed iNikem closed 3 years ago

iNikem commented 3 years ago

Proposal how to leverage wider community contributing instrumentations and other packages

carlosalberto commented 3 years ago

Overall LGTM

carlosalberto commented 3 years ago

@open-telemetry/specs-approvers Please review this, as it looks we are close to have this PR merged.

carlosalberto commented 3 years ago

@iNikem We are ready to merge your PR, thanks. Please solve the small comments, and let's add notes on the things that we should consider doing in the future (e.g. what @jmacd said about " see support for testing OpenTelemetry instrumentation be included in the core of OTel packages", so we don't forget). Thanks!

iNikem commented 3 years ago

@carlosalberto I am not sure I understand what note should I add where. Currently this OTEP calls for a test harness to verify that instrumentations follow model recommendations and semantic conventions. This is already written. What else should include here? I kinda assume as obvious that core Otel packages test existing instrumentations that we produce. If not this is a more fundamental problem not specific to this OTEP.