search

open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
337 stars 164 forks source link

Add remote sampler spec #167

Closed pavolloffay closed 3 years ago

pavolloffay commented 3 years ago

Signed-off-by: Pavol Loffay p.loffay@gmail.com

pavolloffay commented 3 years ago

Related request for regex-based matching for Jaeger remote sampler https://github.com/jaegertracing/jaeger/issues/3133

pavolloffay commented 3 years ago

I am closing this and I will open a PR to document Jaeger remote sampler in the spec.

The work for remote sampler in the OTES will be divided into a control plane and the sampler implementation.

willarmiros commented 3 years ago

@pavolloffay was the PR for Jaeger remote sampler this one? https://github.com/open-telemetry/opentelemetry-specification/pull/1791

Do you still have an intention of defining a more generic remote sampling specification, or is that on hold for now because the jaeger remote sampler is included in the spec?

pavolloffay commented 3 years ago

There are plans for a native OTEL remote sampler. The sampling WG is going to focus on it in the future.

willarmiros commented 3 years ago

Sounds good, I will drop in on a sampling SIG meeting in the future. FWIW, here is the design doc for the X-Ray remote sampler in otel: https://docs.google.com/document/d/11V1CDr6eLoMq_3cK1bUm0GzYEyhEiI_83QEJMUFfu9g/edit?usp=sharing