open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
337 stars 164 forks source link

Instrumentation layers and suppressing duplicates #172

Closed lmolkova closed 1 year ago

lmolkova commented 3 years ago

Proposal to create clarity on instrumentation layers interaction and how to suppress duplicate layers (e.g. multiple instrumented HTTP clients layers).

cc @trask

lmolkova commented 3 years ago

@iNikem I hear your concern to have no suppression at all - I added an open question. I'd still like to understand why we'd need it and how common this need it.

lmolkova commented 3 years ago

Based on the discussions on the instrumentation SIG meeting, I've changed this OTEP to minimize tracing API changes. With the current approach, instrumentation specifies type at span creation time and SDK returns a suppressed span that's very similar to sampled-out, except it never becomes current.

Example: https://github.com/lmolkova/opentelemetry-java/pull/1/files#diff-48014f0437bde243933a6c8902a1f386fab6c78d6777019f24db1951e0070fc4

Open questions:

tedsuo commented 1 year ago

@trask @lmolkova is this something the HTTP semconv working group would like to pick up again?

trask commented 1 year ago

@trask @lmolkova is this something the HTTP semconv working group would like to pick up again?

the scope of the current incarnation of the HTTP semconv working group is "just" stability. we discussed this and believe it can be addressed post-stability.