search

open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
337 stars 164 forks source link

Fix missing apply_to_spans in OTEP 0152 #180

Closed tigrannajaryan closed 2 years ago

tigrannajaryan commented 3 years ago

The OTEP text correctly says:

In addition it is also possible to optionally specify spans and events that the transformation should apply to.

However, the block after that text is missing the apply_to_spans that the text alludes to. I wrote the text correctly but made a mistake when copy/pasting the yaml from my experimental codebase.

I consider this to be a non-breaking change. It is a bug fix since the tag in yaml is supposed to be there according to the text.

Also clarified that the condition is an AND.

tigrannajaryan commented 3 years ago

Alternatively, if we do consider it a breaking change and not a bug fix, I will change the text to match the yaml. (But I think bug fix is the right approach in this case).

tigrannajaryan commented 3 years ago

As discussed in spec SIG meeting, this is not a breaking change it is not yet part of the spec, so we are allowed to fix the OTEP before merging it with the spec.

tigrannajaryan commented 2 years ago

@open-telemetry/specs-approvers please review.

tigrannajaryan commented 2 years ago

https://github.com/open-telemetry/opentelemetry-go/pull/2267 is blocked on this.