open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
337 stars 164 forks source link

Allow omitting LogRecord in favor of build pattern in Logging SDKs #183

Closed tigrannajaryan closed 2 years ago

tigrannajaryan commented 2 years ago

The discussion while implementing the Java SDK revealed that the LogRecord data type may not be necessary. See here https://github.com/open-telemetry/opentelemetry-java/pull/3759#discussion_r738019425

However, in some other languages LogRecord fits nicely (see the comment about Python implementation in the same comment thread).

This changes allows implementators of the OTEP to choose the most idiomatic approach for their language.

tigrannajaryan commented 2 years ago

@open-telemetry/specs-approvers I need 2 more approvals on this small amendment please.

tigrannajaryan commented 2 years ago

@open-telemetry/specs-approvers please review.