search

open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
326 stars 157 forks source link

Add Sampling SIG research notes #213

Open spencerwilson opened 1 year ago

spencerwilson commented 1 year ago

The scope of the OTEP (that appears in this PR in partial form) is a prerequisite to https://github.com/open-telemetry/oteps/issues/191.

This PR needn't be merged. Its purpose is to provide a vehicle for review and iteration by the Sampling SIG. I previously distributed these documents as GitHub gists, but the SIG decided this would be superior to that. I expect that at some point this PR will have served its purpose and at that point may be closed.

jmacd commented 1 year ago

FYI I would like to merge this for the record. Thank you @spencerwilson!!

bputt-e commented 1 year ago

Not sure if this is something this PR will address, but we were experimenting with a client/api that enabled folks to set their sampling rate by span attributes. Using RQL would allow =, !=, regex, like/not like statements and would give more control over the data being traced. Yes, it does require the information that's being used to determine the sampling rate at the first time a span is created.

Our use case was to enable folks to increase sampling rates for a given value (or set of values) without having to make any code changes and the "sampling rules" would re-compile each time it got a change from the API (i.e. when a user makes a change). Moving forward, RQL isn't required, but flexibility could be helpful IF folks want more than = / != for comparing span attributes to something they want to sample by.

tedsuo commented 11 months ago

@spencerwilson we are cleaning up stale OTEP PRs. If there is no further action at this time, we will close this PR in one week. Feel free to open it again when it is time to pick it back up.