open-telemetry / oteps

OpenTelemetry Enhancement Proposals
https://opentelemetry.io
Apache License 2.0
326 stars 157 forks source link

Add chain ID attribute #228

Open lameiraatt opened 1 year ago

lameiraatt commented 1 year ago

This OTEP proposes the addition of a chain ID attribute to spans and logs that supports data processing/analysis and can be implemented as part of an extension to the default OTel SDK.

Feedback welcome and appreciated! 😊

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

bputt-e commented 1 year ago

Does this proposal help with linked spans? Let's say I have 500 traces that get 'merged' into a new trace....What would that new trace look like, would it have any 'historical' knowledge to add any chain info or would it be considered a new trace and have nothing starting out.

joe-elliott commented 1 year ago

fwiw, Tempo achieves similar functionality by computing the nested set model for the tree upon storage. if this were adopted by OTEL it would make calculating the nested set quite a bit easier.

the UUID passed seems to be used to track the root process instance. imo it would be better to make this separate from the concept of the hierarchy. perhaps two different attributes that could be independently controlled:

Perhaps something like: chain.hierarchy chain.root

i'm also a bit concerned about traces with extreme depth creating enormous chain ids. perhaps a configuration option for max depth recorded would be worthwhile?

tedsuo commented 11 months ago

@lameiraatt we are cleaning up stale OTEP PRs. If there is no further action at this time, we will close this PR in one week. Feel free to open it again when it is time to pick it back up.