open-telemetry / prometheus-interoperability-spec

Workgroup for building Prometheus-OTLP interoperability for the OTEL Collector and Prometheus related discussions.
Apache License 2.0
41 stars 6 forks source link

Isolate tests for staleness markers and up metric tests out of TestEndToEnd #59

Closed odeke-em closed 3 years ago

odeke-em commented 3 years ago

We currently have some difficulty with the OpenTelemetry Collector Prometheus receiver's TestEndToEnd because that code was written in 2019 and didn't account for staleness markers (PR for https://github.com/open-telemetry/opentelemetry-collector/pull/3423) nor the up metric per PR https://github.com/open-telemetry/opentelemetry-collector/pull/3116

@Aneurysm9 suggested that perhaps we can move out assertions on the Up metric and the staleness markers out of that test and into their own tests. /cc @alolita