search

open-telemetry / semantic-conventions-java

Java generated classes for semantic conventions
Apache License 2.0
14 stars 17 forks source link

Semconv 1.24.0 #46

Closed jack-berg closed 5 months ago

jack-berg commented 7 months ago

Depends on #45.

jack-berg commented 5 months ago

45 is merged so this is ready for review.

jack-berg commented 5 months ago

These are always weird to review, because it's mostly generated code right? In any case, I did review it, seems ok to me.

Its all generated code. To some extent you can rely on the build passing to help give you confidence in the output, since the build will run code generation and detect any difference. The one thing it doesn't check is if there are are files which are part of the commit, but which are not generated anymore. For example, this commit excludes the aspnetcore and signlar root namespaces, but the build would have passed even had I not manually deleted the AspnetcoreIncubatingAttributes and SignalrIncubatingAttributes files.