search

open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
220 stars 141 forks source link

Semantic conventions for SIP protocol #1114

Open sirzooro opened 2 years ago

sirzooro commented 2 years ago

Please define semantic conventions for SIP protocol. It is similar to HTTP protocol, so mostly it would be enough take existing conventions for HTTP and replace http with sip.

One tricky part which needs special attention is how to create spans for 3-way handshake: INVITE -> 200 OK -> ACK. Additionally client can send CANCEL before it receives 200 OK for INVITE to cancel it - this scenario also needs some explanation.

reyang commented 2 years ago

@sirzooro thanks for reaching out! Do you have connections with the domain experts who could participate in this effort, and if any one of you or the domain experts would be willing to drive this?

amccool commented 2 months ago

+1 we have a need for a common spec in both C# and C code. Not to mention the inclusive of sip proxy servers

jmurphyau commented 1 month ago

I'm currently developing a SIP application and adding metrics/traces/logs and tried to find a standard definition for this stuff with no luck - but did find this PR.

What would someone have to do to actually make progress on this?

From what I can gather, I'd need to create a PR in open-telemetry/semantic-conventions (a new file model/registry/sip.yaml) ?

I suspect after that it would be a few more things, like a PR to add docs to the opentelemetry.io website etc? But changing semantic-conventions looks to be the first step

I've been working with SIP for close to 20 years now - so I think I should be able to get a good start on something like this (time permitting) and should be able to find a few people that can review or provide input.