search

open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
256 stars 165 forks source link

k8s: new attributes: CSI driver and volume handle #1119

Closed gdvalle closed 2 weeks ago

gdvalle commented 4 months ago

Area(s)

Semantic convention for otelcol's kubeletstatsreceiver, area:k8s.

Is your change request related to a problem? Please describe.

In k8s, I would like to record CSI driver and volume handle information for relevant Persistent Volume Claims (PVCs) to be able to associate metrics to underlying disks.

Describe the solution you'd like

Two new attributes, with each mapping 1:1 to the respective driver/volumeHandle fields in CSIPersistentVolumeSource:

And a new value for the k8s.volume.type attribute, csiPersistentVolume.

Describe alternatives you've considered

None

Additional context

This grew from https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32055

ChrsMark commented 3 months ago

/cc @open-telemetry/semconv-k8s-approvers

Also related to https://github.com/open-telemetry/semantic-conventions/issues/1032

ChrsMark commented 2 months ago

There is no semantic convention for the k8s.volume.type. https://github.com/open-telemetry/semantic-conventions/issues/1164 will add this.

mx-psi commented 2 months ago

I removed this from the system semantic conventions WG since this WG does not handle Kubernetes-related semantic conventions