search

open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
272 stars 174 forks source link

Could we remove `tls.client.server_name` in favor of `server.address` #1211

Closed lmolkova closed 3 months ago

lmolkova commented 4 months ago

tls.client.server_name is defined as https://github.com/open-telemetry/semantic-conventions/blob/5971366ae2fcaf2d01b1a52da92e872b7df5491d/docs/attributes-registry/tls.md?plain=1#L25

This should be the same as server.address. See https://community.f5.com/kb/technicalarticles/ssl-profiles-part-7-server-name-indication/279829

So the proposal is to deprecate the tls.client.server_name attribute.

joaopgrassi commented 4 months ago

CC @svrnm

svrnm commented 4 months ago

When I added this originally I took most attributes from Elastic Common Schema, so I had no other reason than that for adding it.

+1 for deprecation