Closed ChrsMark closed 2 months ago
@open-telemetry/semconv-k8s-approvers could you take a look?
Thank's @lmolkova for the comments! Should be addressed now.
Hey @jsuereth, could you take another look please?
The failure is unrelated. I have filed https://github.com/open-telemetry/semantic-conventions/pull/1332 to fix this.
Fixes https://github.com/open-telemetry/semantic-conventions/issues/1164
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Add k8s.volume.{name,type} attributes.
From https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.102.0/receiver/kubeletstatsreceiver/internal/kubelet/conventions.go#L7
Merge requirement checklist
[chore]