open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
261 stars 167 forks source link

Add k8s.volume.{name,type} attributes #1251

Closed ChrsMark closed 2 months ago

ChrsMark commented 3 months ago

Fixes https://github.com/open-telemetry/semantic-conventions/issues/1164

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Add k8s.volume.{name,type} attributes.

From https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.102.0/receiver/kubeletstatsreceiver/internal/kubelet/conventions.go#L7

Merge requirement checklist

ChrsMark commented 2 months ago

@open-telemetry/semconv-k8s-approvers could you take a look?

ChrsMark commented 2 months ago

Thank's @lmolkova for the comments! Should be addressed now.

ChrsMark commented 2 months ago

Hey @jsuereth, could you take another look please?

ChrsMark commented 2 months ago

The failure is unrelated. I have filed https://github.com/open-telemetry/semantic-conventions/pull/1332 to fix this.