Open mx-psi opened 1 year ago
.limit
is probably the closest existing convention: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md#instrument-naming
Thanks, I changed all .total
suffixes by .limit
suffixes above :)
Curious for next steps, will there be a PR for this change to semantic convention?
Curious for next steps, will there be a PR for this change to semantic convention?
@yevgentrukhin yes, this is part of the system semantic conventions WG roadmap and will be addressed before stabilization of system metrics. If you are interested in having this sooner, I am happy to review PRs related to this and you can join our weekly meeting to discuss if necessary (see here for details)
Clarify set of attribute values for system.memory.usage state and consider using system.memory.total
I have marked this one as done, since #89 we have the the total
value for state which would be system.memory.limit
Discussed on January 18th System Semantic Conventions WG meeting, we don't consider this one to be a blocker for system metrics GA unless the new metrics affect existing metrics. @mx-psi to double check this.
@joaopgrassi Sorry, I think in the https://github.com/open-telemetry/semantic-conventions/pull/1356 PR I did not specify that it was partially solving this issue. I reckon system.filesystem.limit
and system.paging.limit
metrics still need to be added.
Current system metrics cover usage of memory, paging/swap memory and filesystems, but we don't currently support the total capacity of any of these systems as a separate metric.
The following metric can't be recovered from the existing system metrics and would need to be added to support this:
The following metric may be recovered from
system.memory.usage
, but the current description of the attribute values ofstate
is insufficient to recover this.The following metrics are available as the sum of
used
andfree
(andreserved
for the file system one). They could be added as a convenience metric:Items for this issue:
system.disk.limit
to the specificationsystem.memory.usage
state and consider usingsystem.memory.total
system.filesystem.limit
andsystem.paging.total
if convenience justifies itThis would be part of open-telemetry/opentelemetry-specification/issues/3556 if approved.