[chore] Mention JavaAgent v2.0.0 default behaviour

open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains

Apache License 2.0

284 stars 175 forks source link

[chore] Mention JavaAgent v2.0.0 default behaviour #1533

Open devurandom opened 3 weeks ago

devurandom commented 3 weeks ago

Changes

HTTP semantic convention stability migration docs ^1 do not mention that the JavaAgent v2.0.0 already defaults to the new, stable behaviour ^2, which could lead to people believing they have to set OTEL_SEMCONV_STABILITY_OPT_IN=http when they don't.

This does not change an actual convention, thus I believe it does not need a changelog entry.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.
[ ] Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with [chore]
[ ] schema-next.yaml updated with changes to existing conventions.

linux-foundation-easycla[bot] commented 3 weeks ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: devurandom / name: Dennis Schridde (24f371755f82cccfe30176ba97d037e03bf200f5, 2a4c2bf4a5abe751d566de84cc4d0f8d7c4db2dd)

arminru commented 3 weeks ago

@open-telemetry/java-instrumentation-maintainers FYI

trask commented 3 weeks ago

@devurandom a related discussion has been taking place in #534, can you review that issue? thanks

devurandom commented 3 weeks ago

a related discussion has been taking place in #534, can you review that issue?

Thanks for the hint. I was not aware of that issue.

My PR is (to a limited degree) addressing his point in https://github.com/open-telemetry/semantic-conventions/issues/534#issuecomment-1816832645: I point out that, if you're using Java agent v2.0.0 or later, the migration does not apply to you.

I do not feel qualified to address the wider-scope suggestions he points out, like https://github.com/open-telemetry/semantic-conventions/issues/534#issuecomment-1834604634 to create a table for all supported languages, that fully address the issue and could close it.

trask commented 3 weeks ago

I point out that, if you're using Java agent v2.0.0 or later, the migration does not apply to you.

if you are upgrading from Java agent 1.x to 2.x, I think it does apply to you

github-actions[bot] commented 5 days ago

This PR was marked stale due to lack of activity. It will be closed in 7 days.