open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
282 stars 175 forks source link

Use project version of markdown-link-check package #1562

Closed joaopgrassi closed 2 weeks ago

joaopgrassi commented 2 weeks ago

Changes

The changelog.yaml workflow is installing the latest version of the markdown-link-check package on each run, and the latest version seems to have a issue (See #1552).

Adding a make target to run this task, so then it uses the version defined in package.json for the repo.

Merge requirement checklist

christophe-kamphaus-jemmic commented 2 weeks ago

Is there a commit on which the changelog workflow succeeded and wasn't skipped?

joaopgrassi commented 2 weeks ago

Is there a commit on which the changelog workflow succeeded and wasn't skipped?

No. The problem is that I added the new make target, but I can't use it in the workflow yet, since it fails because the new target is not there. So I guess we will only know when it merges. I only tested it locally and all worked.

joaopgrassi commented 2 weeks ago

Let's see if it works 😅