search

open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
220 stars 141 forks source link

dynamodb attributes are in aws namespace instead db #186

Open Flarna opened 12 months ago

Flarna commented 12 months ago

The span attributes for dynamodb are currently in aws namespace.

Other databases like mondodb or mssql have their special attributes in the db namespace.

At other places like cloud.region vendor namespaces are also replaced/avoided by a generic namespace.

Should the dynamodb attributes moved to db namespace?

Oberon00 commented 12 months ago

I think it's kind of a wash. All aws-API-specific attributes start with aws., all db-related ones with db.. You can't have both. There are some remarks regarding use of db.* e.g. at https://github.com/open-telemetry/opentelemetry-specification/pull/1422#issuecomment-789672353

joaopgrassi commented 4 months ago

This was closed by mistake by the stale bot. Re-opening

joaopgrassi commented 4 months ago

fyi @trask

trask commented 2 months ago

I'd vote for the db.* prefix to be given precedence since that seems like the more important grouping from semantic convention perspective.

trask commented 2 months ago

even if we aren't targeting dynamodb as part of initial database semconv stability, I think we should make this change as part of the initial database semconv stability process so that this breaking change could benefit from being grouped with the other breaking changes related to stabilization

trask commented 1 month ago

I thought about this some more and changed my opinion.

we should try to stick with the philosophy "try to consolidate all breaking changes into a single bump when going stable"

and so we should defer this change until we are planing dynamodb semconv stabilization (which is not included as part of initial db semconv stability)