open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
262 stars 167 forks source link

Create labels for semantic-conventions repository #22

Open arminru opened 1 year ago

arminru commented 1 year ago

In the spec, we currently distinguish between the following semconv-related aspects:

(see https://github.com/open-telemetry/opentelemetry-specification/labels)

Should we follow the same pattern here or come up with a new approach?

reyang commented 1 year ago

Here is what I suggest:

  1. Do not have the artificial separation of trace/metrics/logs/resource - we want semantic conventions to be defined across all the telemetry signals (e.g. HTTP status could should apply to logs/metrics/traces.
  2. Instead of using labels for areas (e.g. database), just use folder structure (combined with issue template).
joaopgrassi commented 1 year ago

Instead of using labels for areas (e.g. database), just use folder structure (combined with issue template).

Not sure if I'm missing something, but how would using folder structure replace using labels? Or did you mean use the same "folder structure" as labels? If we want to move away from semconv specific to signals, using "areas" sounds the best approach, no?

joaopgrassi commented 7 months ago

I think this is related to this and my suggestion is documented: https://github.com/open-telemetry/semantic-conventions/pull/292#issuecomment-1908486583. Essentially we could create labels for the areas we have in the registry.

joaopgrassi commented 6 months ago

Now that https://github.com/open-telemetry/semantic-conventions/pull/777 was merged, and we have labels for areas that match the files in model/registry should we close this?