open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
256 stars 165 forks source link

Request to create semconv-mobile-approvers #343

Closed AlexanderWert closed 1 year ago

AlexanderWert commented 1 year ago

I'd like to request creating a new approvers group semconv-mobile-approvers that would be responsible for reviewing and maintaining semantic conventions related to the mobile domain (e.g. iOS, Android).

Folks proposed for that group / interested:

Related PRs and issues:

breedx-splk commented 1 year ago

Count me in. Thanks!

surbhiia commented 1 year ago

If you need more approvers from Android, I would like to participate as well. :)

marandaneto commented 1 year ago

Same, I'd like to contribute as an approver if possible.

bryce-b commented 1 year ago

I'm in

arminru commented 1 year ago

I created @open-telemetry/semconv-mobile-approvers and added everyone stated in the description who is already a member of the OTel organization.

You can go ahead and update the code owners file to cover the subpaths where the mobile semantic conventions will reside.

@bidetofevil @surbhiia @marandaneto please take a look at our community membership guidelines and follow the process documented there for becoming a member so I can add you as well.

marandaneto commented 1 year ago

@arminru do you mean this?

arminru commented 1 year ago

@marandaneto Exactly! Thanks for the link, I forgot to paste it above 🙂

marandaneto commented 1 year ago

@marandaneto Exactly! Thanks for the link, I forgot to paste it above 🙂

Done, the issue is open, but I don't have sponsors nor have previously contributed directly. How do I proceed? do I need to reach out to folks and try to get sponsors on my own? Also, do I need to contribute before being part of the new group?

arminru commented 1 year ago

Hey @marandaneto!

Only to become a formal approver you'd first need to be a community member, for which the requirements are defined in the community repo.

You're more than happy to already contribute to all efforts, working groups and discussions also as someone new to OpenTelemetry, and you're also able to review PRs. The only difference is that only approvals from formal approvers count towards our merge requirements.

The requirement for having sponsors for membership requests is to ensure those sponsors are able to confirm someone is a credible contributor with good reasoning. Once you've contributed to OTel for a bit, it should be easy for others in the community to make such judgments and sponsor your request.

surbhiia commented 1 year ago

Thanks @arminru for sharing the details. I've created an issue here to become a member. I'll let you know once it's closed.

arminru commented 1 year ago

Team created and added to CODEOWNERS.