search

open-telemetry / semantic-conventions

Defines standards for generating consistent, accessible telemetry across a variety of domains
Apache License 2.0
256 stars 165 forks source link

Change `device` prefix to `mobile` for mobile events? #548

Open AlexanderWert opened 10 months ago

AlexanderWert commented 10 months ago

With https://github.com/open-telemetry/semantic-conventions/pull/473 the event.domain and event.name are merged into a single field, where event.domain becomes a prefix.

So new event names for the mobile space will be something like device.app.lifecycle. I'm wondering why we are using the device namespace for things that are mobile-related. Device can stand for anything, while we explicitly target mobile devices here.

How about changing the device prefix to mobile so the event name would be something like mobile.app.lifecycle ?

@open-telemetry/semconv-mobile-approvers WDYT?

To be clear: I am NOT proposing to change the device resource attributes, though!

LikeTheSalad commented 10 months ago

I wasn't part of the decision to use device as a way to identify mobile events so I couldn't tell for sure what's the reasoning behind it, however, one thing that comes to my mind would be that, at least for Android, you can run apps on TVs too, so it might not be fully correct to call them "mobile devices", however, I also don't think it would be too confusing to do so since I guess people should understand that, when we refer to "mobile", we're talking about Android OS and iOS, so I don't have strong opinions for not making the change, though it would probably be nice to have some description in the docs that explains what "mobile" means in this context.

joaopgrassi commented 7 months ago

Hey all, any change in this subject? Are any of you interested in proposing the changes for this?