JQ errors are suppressed - Githubissues

open-telemetry / weaver

OTel Weaver lets you easily develop, validate, document, and deploy semantic conventions

Apache License 2.0

52 stars 19 forks source link

JQ errors are suppressed #264

Closed lmolkova closed 2 months ago

lmolkova commented 2 months ago

JQ errors are ignored during registry generation / markdown update.

To Reproduce

Define a weaver.yaml like
```
- pattern: readme.md.j2
  filter: 'error("foo")' # or do something that'd result in JQ error
 ...
```
(e.g. change one in semconv https://github.com/open-telemetry/semantic-conventions/blob/a44ff768718b6e82f2dea42189ba14712c795e6b/templates/registry/markdown/weaver.yaml)
Run generation

Expected behavior

registry generation fails.
JQ error is propagated in the output
generation stops

Actual behavior

original groups are passed to jinja as if there was no JQ filter
generation continues and fails later in jinja templates (if JQ modified the structure) or results in incorrect data (if structure is the same, but filters didn't run),

lquerel commented 2 months ago

Fixed in #274