Data type refactor restructuring and changes

[Vibaswan]

Fixes #436 Fixes #437 Fixes #438

[ashutshkumr]

Do we need this snippet ? Why ?

        if "enums" in xpattern:
            schema["properties"]["value"]["enum"] = copy.deepcopy(
                xpattern["enums"]
            )
            schema["properties"]["values"]["items"]["enum"] = copy.deepcopy(
                xpattern["enums"]

[ashutshkumr]

Do we need this too ? can't it be deepcopied directly to schema ?

        xconstants = (
            xpattern["x-constants"] if "x-constants" in xpattern else None
        )

[ashutshkumr]

This is again coming from old code, but shouldn't we check if counter feature is provided before defining Incr/Decr schemas ?

        if xpattern["format"] in ["integer", "ipv4", "ipv6", "mac"]:
            counter_pattern_name = "{}.Counter".format(schema_name)

[Vibaswan]

these were from beginning not sure of the use-cases

[ashutshkumr]

these were from beginning not sure of the use-cases

Would suggest removing any unused code, hence asking for confirmation if it's indeed used

[ashutshkumr]

We're not setting correct format for auto field (for integer)

[ashutshkumr]

Do not provide minimum and maximum for properties which require exact 32/64 bits.

[Vibaswan]

We're not setting correct format for auto field (for integer)

already showcased this

[Vibaswan]

these were from beginning not sure of the use-cases

Would suggest removing any unused code, hence asking for confirmation if it's indeed used

removed unused code

[ashutshkumr]

Still see some consistency issues in bundler.py:

• If minimum is 0, no need to set it (specifically for x-field-patterns)
• Why don't we _apply_common_x_field_pattern_properties on count ?
• The logic for inclusion of counter schema should be fixed - currently we only include count property if count feature is selected; Ideally the entire schema shouldn't be generated at all if count feature is not selected.

[ashutshkumr]

empty string not needed

                    pt.get("type", "") == "int" or pt.get("itemtype") == "int"

[ashutshkumr]

Inside _get_integer_format, if type_format is None, set it to int32

[ashutshkumr]

needs to be and

    def _min_max_in_range(cls, format, min, max):
        if min is None or max is None:
            return True

[ashutshkumr]

Remove _format_from_range and its usage. Print a WARNING that since format has not been provided, it's being defaulted to int32

[ashutshkumr]

Probably need to include map for int32

self._oapi_go_types = {

[ashutshkumr]

Remove

                elif property_schema["format"].lower() in self._oapi_go_types:
                    go_type = "{oapi_go_type}".format(
                        oapi_go_type=self._oapi_go_types[
                            property_schema["format"].lower()
                        ]
                    )

[ashutshkumr]

use startswith

if "uint" in field.type and field.min == 0:
                    pass