Closed Vibaswan closed 1 month ago
It is quite difficult to predict ultimate collateral, just looking into the changes (#469). Overall, it looks like we are splitting files according to the objects. So, I have put these generic review comments:
- We are end-up with huge numbers of files. Thing is really ugly for
pattern_flow_*.go
. (https://github.com/open-traffic-generator/snappi/tree/split_gosnappi/gosnappi). I do not have ready solution, but what about if we use some pattern matching using object name also (say if we matchpattern_flow_rsvp_path*
then 128 files will club into one file) . At the same time we already got review from google, so I don’t want to drag it farther.- We must build controller and run entire CI using this snappi (with enable split flag) to make sure split not left any structure.
- Generate a snappi build without split flag. There gosnappi should exact match with gosnappi of main branch.
we have checked for points 2 and 3
It is quite difficult to predict ultimate collateral, just looking into the changes (https://github.com/open-traffic-generator/openapiart/pull/469). Overall, it looks like we are splitting files according to the objects. So, I have put these generic review comments:
pattern_flow_*.go
. (https://github.com/open-traffic-generator/snappi/tree/split_gosnappi/gosnappi). I do not have ready solution, but what about if we use some pattern matching using object name also (say if we matchpattern_flow_rsvp_path*
then 128 files will club into one file) . At the same time we already got review from google, so I don’t want to drag it farther.