gosnappi BGP `as_number` field uses signed int32 - not enough for 4-byte ASN value range

open-traffic-generator / snappi

Open Traffic Generator SDK in Python and Go

MIT License

70 stars 7 forks source link

gosnappi BGP `as_number` field uses signed int32 - not enough for 4-byte ASN value range #195

Closed bortok closed 9 months ago

bortok commented 1 year ago

4-byte BGP ASN must accept values in the range from 0 to 2^32-1 (https://www.arin.net/resources/guide/asn/) This requires use if uint32 to represent ASNs, not int32 currently in use by gosnappi. Using int32 leads to the values from 2^31-1 to 2^32-1 to be negative.

apratimmukherjee commented 1 year ago

Plan is to fix this as part of data refactor with modification of format to new option available uint32 ( https://jira.it.keysight.com/browse/ATHENAG-474 )

bortok commented 9 months ago

Confirming as fixed in v0.12 with migration to unsigned int32