search

open-traffic-generator / snappi

Open Traffic Generator SDK in Python and Go
MIT License
72 stars 7 forks source link

Handling Defaults and Required params #69

Closed Rangababu-R closed 3 years ago

Rangababu-R commented 3 years ago

Let me know if this approach is as per the standard.

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging c646babb8da9bea7ec6d3ed70788beccc1e78291 into 366b9096c177234d5657eba94ba278ccf225ea82 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 98e5f5e46196468ab7e7181923755c7ccebea7b1 into 9e95e6e44f41a75cde6b667272c48256c9c86496 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging ead0eafb30a72727558fcde7180e32d5aa6e857c into 9e95e6e44f41a75cde6b667272c48256c9c86496 - view on LGTM.com

new alerts:

ashutshkumr commented 3 years ago

@Rangababu-R after syncing with main (which uses models version 0.4.0), there's an existing issue in this implementation that was exposed where contents of values are surrounded by single quotes. e.g. 

    _DEFAULTS = {
        'choice': 'value',
        'value': '00:00:00:00:00:00',
        'values': '['00:00:00:00:00:00']',
    } # type: Dict[str, str]
Rangababu-R commented 3 years ago

moved to Defaults, Required Params and Type assertions PR