Closed jhpoelen closed 4 years ago
Hi @jhpoelen Two first datasets were added, however, the preview is not working. Please check them and let me know how I could fix the error. Then, I'll add the other datasets.
Hey @BErfanian - thanks for proposing the two legacy datasets via https://github.com/open-traits-network/open-traits-network.github.io/pull/129 and https://github.com/open-traits-network/open-traits-network.github.io/pull/128 .
@willpearse @lembrechtsjonas @JonathonMifsud - do you have any ideas on why the pull requests above seem to contain malformed Jekyll yaml front matter ? Perhaps using tools like http://www.yamllint.com/ help to highlight funny syntax errors.
Hi @jhpoelen I've checked both files in yamllint, the answer was: Valid YAML!
Hi @jhpoelen @BErfanian
Like @BErfanian both files were valid in yamllint. I noticed that the end of bennett-2019 line 10 contains a tab, are these invalid in YAML? https://github.com/open-traits-network/open-traits-network.github.io/blob/914f351e70aa40828f67ed6e85ee5d5764df9248/_datasets/bennett-2018#L10
I haven't spotted anything in #128 yet.
I haven't had any experience with YAML so this was just a guess!
Thanks @JonathonMifsud for taking a peek at this.
@BErfanian I realize it might be frustrating to figure this thing out. . . I admire your persistence and care you take to make sure to understand what is happening.
One thing I sometimes do to troubleshoot formatting issues is to run the site locally on my laptop using "jekyll" command-line tool:
steps are something like:
Here's the output I see when I run it on my laptop:
$ jekyll s
Configuration file: /xxxx/open-traits-network.github.io/_config.yml
Source: /xxxx/open-traits-network.github.io
Destination: /xxxx/open-traits-network.github.io/_site
Incremental build: disabled. Enable with --incremental
Generating...
Jekyll Feed: Generating feed for posts
done in 9.734 seconds.
Auto-regeneration: enabled for '/xxxx/opentraits/open-traits-network.github.io'
Server address: http://127.0.0.1:4000/
Server running... press ctrl-c to stop.
If the dataset page related to your additions look fine on your local machine, it might just be a github website issue. Otherwise, you'll probably see jekyll logging error messages.
Hope this helps!
Hi @JonathonMifsud Thanks for the suggestion @jhpoelen I'll check it in Jekyll
Hi @jhpoelen
Configuration file: c:/check/_config.yml
Source: c:/check
Destination: c:/check/_site
Incremental build: disabled. Enable with --incremental
Generating...
Jekyll Feed: Generating feed for posts done in 5.157 seconds.
Auto-regeneration: enabled for 'c:/check'
Server address: http://127.0.0.1:4000/
Server running... press ctrl-c to stop.
Everything looks ok on the local site.
@BErfanian Thanks for making the effort to check the additions! This result suggests that the Github preview might not work all the time.
@BErfanian the root cause of the issue was the the added files did not have ```.md```` file extensions.
I fixed the issue via https://github.com/open-traits-network/open-traits-network.github.io/commit/8ffb003bfe2c0b80bb7bf712ef1a8582935466fb .
All datasets were added to the site.
legacy OTN dataset registration 7 from #45 as suggested by @bmaitner