search

open-vsx / publish-extensions

Scripts for publishing VS Code extensions to open-vsx.org
Eclipse Public License 2.0
237 stars 201 forks source link

Please add Gitlens Fork before it was owned by GitKraken #680

Open lamyergeier opened 1 year ago

lamyergeier commented 1 year ago

This extension is available on vscode at : [GitLess - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=maattdd.gitless)

Repository: maattdd/vscode-gitlens

filiptronicek commented 1 year ago

Hi there @lamyergeier 👋!

I think there is no harm in one-time publishing this extension, but does it really do what you suggest it does? I see GitKraken links in this version already 🤔

image
lamyergeier commented 1 year ago

@filiptronicek

Yes there are Gitkraken links but all features are free upto that git commit. Read: [GitLess - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=maattdd.gitless)

filiptronicek commented 1 year ago

@lamyergeier can you check that https://open-vsx.org/extension/maattdd/gitless is published correctly?

lamyergeier commented 1 year ago

@filiptronicek It is not correct. When installed in Codium it shows extension version as v12. While when I install the extension in Microsoft VSCode it shows v11.7 as follows

image

filiptronicek commented 1 year ago

@lamyergeier ok, I can unpublish this version. Do you know where the extension would be published from exactly? I don't see any difference in the fork - no commits added by @maattdd. I'm looking for the actual source code from which they published it.

GitMensch commented 1 year ago

Hm, I also see that - the version in the marketplace just doesn't have any matching branch / tag in the repo - so there is no use in the extra publishing from the repo.

Also open-vsx already include the "completely free" version https://open-vsx.org/extension/eamodio/gitlens/11.7.0 (and with the missing additional commits and an "active" fork where changes are actually done (for example each change from the official version that doesn't change anything in the "plus" directory could be merged in - because this is the sole directory that has a different license.

filiptronicek commented 1 year ago

Also open-vsx already include the "completely free" version

Thanks for pointing that out @GitMensch, we really have been publishing that extension for a long time now haha!

If we cannot get the actual source code, I think I'll raise a removal request for the extension, as it is published incorrectly and it doesn't seem we'll resolve this here by ourselves.