Add `ms-vscode.wasm-wasi-core` and `ms-vscode.webshell`

open-vsx / publish-extensions

Scripts for publishing VS Code extensions to open-vsx.org

Eclipse Public License 2.0

225 stars 200 forks source link

Add `ms-vscode.wasm-wasi-core` and `ms-vscode.webshell` #763

Closed glebbash closed 1 week ago

glebbash commented 3 weeks ago

[x] I have read the note above about PRs contributing or fixing extensions
[x] I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
[x] This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR adds ms-vscode.wasm-wasi-core and ms-vscode.webshell extensions.

Request for the author to add: https://github.com/microsoft/vscode-wasm/issues/152, same situation as with vscode-eslint extension: https://github.com/microsoft/vscode-eslint/issues/1842#issuecomment-2095506576 MIT license: https://github.com/microsoft/vscode-wasm/blob/main/LICENSE

glebbash commented 3 weeks ago

P.S: not sure if the version bump in the build script will be a problem

filiptronicek commented 2 weeks ago

Hey @glebbash, thanks a lot for the contribution. It looks like with the current configuration tsc is not super happy. Could you take a look?

Happy to merge when it compiles

glebbash commented 2 weeks ago

Not sure what was wrong with the previous setup, locally everything worked fine. Updated to custom package scripts.

@filiptronicek can you pls rerun the workflow?

filiptronicek commented 1 week ago

Apparently, typescript still won't budge.

I could reproduce this in a Gitpod workspace using this command:

EXTENSIONS=ms-vscode.wasm-wasi-core,ms-vscode.webshell SKIP_PUBLISH=true node publish-extensions

glebbash commented 1 week ago

Ok, finally figured it out, needed to do npm i in the root of the repository and not in the packages.

glebbash commented 1 week ago

Yo @filiptronicek, any ideas why these extensions were not published?

They are present in the last action report but links to them are 404.

filiptronicek commented 1 week ago

@glebbash I think it may have something to do with https://github.com/eclipse/openvsx/issues/945, which should land shortly. Let's see if tomorrow's or Wednesday's CI job picks it up.

glebbash commented 1 week ago

Yay, there are deployed 😀