open-wa / wa-automate-nodejs

πŸ’¬ πŸ€– The most reliable tool for chatbots with advanced features. Be sure to 🌟 this repository for updates!
https://docs.openwa.dev/
Other
3.15k stars 600 forks source link

I don't know this is bug or not #1380

Closed afrizaloky closed 3 years ago

afrizaloky commented 3 years ago

Describe the bug

i use openwa 3.6.3 i try using sendText with null paramater, sendText(from, null). The function after this sendText can't executed. for example: client.sendText(from, '') => this empty string parameter doesn't make bug client.sendText(from, 'test') => this message can be send client.sendText(from, null) => this message can't be send and the code stop in there client.sendText(from, 'test2') => not executed client.sendText(from, asq) => not executed client.sendText(from, 'test3') => not executed

for another example: client.sendText(from, '') => this empty parameter doesn't make bug client.sendText(from, 'test') => this message can be send client.sendText(from, 'test2') => this message can be send client.sendText(from, asq) => note: asq is undefined variable. this message can't be send and the code stop in there client.sendText(from, 'test3') => not executed

i don't know this is bug or not, but it is annoying for me. sorry for bad documentation

smashah commented 3 years ago

@afrizaloky are you using typescript?

afrizaloky commented 3 years ago

i use nodejs

smashah commented 3 years ago

@github-actions run

⚑ Release! ⚑ ```js (async () => { function exec(cmd) { console.log(execSync(cmd).toString()); } // Config const gitUserEmail = "github-actions[bot]@users.noreply.github.com"; const gitUserName = "github-actions[bot]"; exec(`echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc`); exec(`git config --global user.email "${gitUserEmail}"`); exec(`git config --global user.name "${gitUserName}"`); exec(`npm i -D`); exec(`npm run release-ci`); //comment on the issue var result = execSync(`npx auto-changelog -o ./tempchangelog.txt --commit-limit false --template ./compact-keepachangelog.hbs --stdout`).toString(); await postComment(result); //create changelog image exec(`npm run release-image`); exec(`git commit -a -m 'updated release-image'`); exec(`git push --force`); })(); ```
smashah commented 3 years ago

Changelog

πŸš€ Release 3.6.4 (2021-02-23)

smashah commented 3 years ago

@afrizaloky can you update to the latest version and try to send a text with null or undefined again and see if it gets stuck

afrizaloky commented 3 years ago

closed. thank you