search

open-wa / wa-automate-python

💬 🤖 The most advanced Python whatsapp library for chatbots with advanced features. Be sure to ⭐ this repository for updates!
Other
330 stars 71 forks source link

make wapi.js version configurable starting from 2.0.0 #44

Closed darkash closed 3 years ago

darkash commented 3 years ago

Make wapi.js version configurable

Reason: When the wapi.js from https://github.com/open-wa/wa-automate-nodejs introduced a breaking changes, the user of this library can choose to use the older version of wapi.js rather than waiting a maintainer/contributor to push the changes, which may go unnoticed for few hours. Example of the use case is when wapi.js is bumped to 2.0.0, needing the implementation of patch system on the library.

Limitation: The wapi_version option should only uses 2.0.0 or newer as we will try to match wapi.js version in order to avoid issues

Wxample usage: WhatsAPIDriver(wapi_version="2.0.0") version is taken from release tag: https://github.com/open-wa/wa-automate-nodejs/releases

mrodal commented 3 years ago

Hey, @darkash sorry, I thought it was an issue instead of a PR 😅 because I only saw the email and Im not used to seeing PRs... so I implemented it before realizing it was a PR.. We did almost the exact same changes, its on master and published as version 1.3.8

darkash commented 3 years ago

ok, np just happy that it gets implemented 👍