hdr: Add sys/select.h posix header

winspool commented 6 months ago

Detected, when i tried to compile TinyEMU with OpenWatcom.

In early posix versions, these declarations / defines / macros where in sys/time.h, but since some posix revisions, they belong to sys/select.h.

I tested it on linux, but i can`t test RDOS

-- Regards ... Detlef

jmalak commented 6 months ago

I have a few notes:

implementation comment should not be output to header file, comment defined with two double dots "::" on begining of line
why you write such nonsense to header files, see below, POSIX requires to be defined in both, that OpenWatcom sys/time.h is OK
```
/* Posix requires, that this belongs to sys/select.h
* OpenWatcom had it previously in sys/time.h
*/
```
what value it has for users or programmers, only increase size of header files may be better to define fdset.sp file and include it into both header files
what is purpose of macro HERE_IS_SYS_SELECT_H ?

jmalak commented 6 months ago

I added fdset.sp and select.sp include files (now used in sys/time.h) holding shared definition that only sys/select.h must be implemented

winspool commented 6 months ago

Updated patch on top of the latest changes in the master tree

winspool commented 6 months ago

Thanks for your adjustments.

open-watcom / open-watcom-v2