search

open-watcom / open-watcom-v2

Open Watcom V2.0 - Source code repository, Wiki, Latest Binary build, Archived builds including all installers for download.
Other
989 stars 162 forks source link

wdump: Remove unused defines #1282

Closed winspool closed 5 months ago

winspool commented 6 months ago

Found while study the wdump source

-- Regards ... Detlef

jmalak commented 6 months ago

what's the point? are you sure what these macros mean and if they won't be used anymore? In OW code base is many unused macros, enumeration values. do you plan remove all?

winspool commented 6 months ago

what's the point?

While working on other projects many years before, I was teached to make small, independant patches.

are you sure what these macros mean

I try to understand better, how the code is working to extend wdump and found out, that these defines are unused.

and if they won't be used anymore?

I canged the replacement value to a non existent function call and rebuild OpenWatcom without a build break.

In OW code base is many unused macros, enumeration values. do you plan remove all?

I do not search for them, but when i touch a code area and find someting unused, i remove them.

jmalak commented 6 months ago

It is little bit stupid arguments. General OW rule is don't tuch what is not part of your change. That something is not used is not argument to remove it. Such things could be source of information about code evolution, design, can be reused in the future etc. You cannot know why it is where it is and reason for it. Don't remove such unrelated definition anytime.