jmalak
commented
22 hours ago First note is that Open Watcom create 32-bit application not 64-bit that in 64-bit application can be a little different rules. Second note if you look on standard Open Watcom tools (32-bit) with assigned icon you will see it properly in Windows Explorer. 64-bit version of tools is compiled by Visual Studio that it is not relevant for your case, but it is build from same source code. 64-bit version is also OK in Windows Explorer. OW is capable to do what you want but something is wrong that you didn't get correct result. I am not expert on Windows GUI programming that I can only look on similar case used in Open Watcom source code.
But what you describe has nothing to do with your code, but with resource records only. All our tools has required icon as first, with lowest ID.
It could be some issue with linker which bind your resource records to executable. Try to use Open Watcom resource compiler to add resource records to executable instead of linker. Use command wrc -q -k main.res main.exe
tdechaize
Hi,
Just test an simply code to open a window on W11 (GUI application) with an icon defined into resource file. Normally, if I compile this example with GCC of MinGW64, list of files with used of Explorer see executable with "icon" screened. But, impossible with Open WATCOM V2, I spend many hours to test this, with different options (used "loadimage" in replacement of "loadicon"), nothing work.
Here these simply sources to test :
File main.cpp :
ifndef WIN32_LEAN_AND_MEAN
define WIN32_LEAN_AND_MEAN
endif
include
include "resource2.h"
// // // WndProc - Window procedure // // LRESULT CALLBACK WndProc( HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam) { switch (uMsg) { case WM_DESTROY: ::PostQuitMessage(0); break; default: return ::DefWindowProc(hWnd, uMsg, wParam, lParam); }
return 0; }
// // // WinMain - Win32 application entry point. // // int APIENTRY wWinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance, LPWSTR lpCmdLine, int nShowCmd) { // Setup window class attributes. WNDCLASSEX wcex; ZeroMemory(&wcex, sizeof(wcex));
wcex.cbSize = sizeof(wcex); // WNDCLASSEX size in bytes wcex.style = CS_HREDRAW | CS_VREDRAW; // Window class styles wcex.lpszClassName = TEXT("MYFIRSTWINDOWCLASS"); // Window class name wcex.hbrBackground = (HBRUSH)(COLOR_WINDOW + 1); // Window background brush color. // wcex.hIcon = LoadIcon(GetModuleHandle(NULL), MAKEINTRESOURCE(IDI_ICON_1)); // Windows icon wcex.hIcon = (HICON)LoadImage(GetModuleHandle(0), MAKEINTRESOURCE(IDI_ICON_1), IMAGE_ICON, 0, 0, LR_LOADTRANSPARENT); wcex.hCursor = LoadCursor(hInstance, IDC_ARROW); // Window cursor wcex.lpfnWndProc = WndProc; // Window procedure associated to this window class. wcex.hInstance = hInstance; // The application instance. // wcex.hIconSm = LoadIcon(GetModuleHandle(NULL), MAKEINTRESOURCE(IDI_ICON_1)); // Windows icon wcex.hIconSm = (HICON)LoadImage(GetModuleHandle(0), MAKEINTRESOURCE(IDI_ICON_1), IMAGE_ICON, 0, 0, LR_LOADTRANSPARENT);
// Register window and ensure registration success. if (!RegisterClassEx(&wcex)) return 1;
// Setup window initialization attributes. CREATESTRUCT cs; ZeroMemory(&cs, sizeof(cs));
cs.x = 0; // Window X position cs.y = 0; // Window Y position cs.cx = 640; // Window width cs.cy = 480; // Window height cs.hInstance = hInstance; // Window instance. cs.lpszClass = wcex.lpszClassName; // Window class name cs.lpszName = TEXT("My First Window"); // Window title cs.style = WS_OVERLAPPEDWINDOW; // Window style
// Create the window. HWND hWnd = ::CreateWindowEx( cs.dwExStyle, cs.lpszClass, cs.lpszName, cs.style, cs.x, cs.y, cs.cx, cs.cy, cs.hwndParent, cs.hMenu, cs.hInstance, cs.lpCreateParams);
// Validate window. if (!hWnd) return 1;
// Display the window. ::ShowWindow(hWnd, SW_SHOWDEFAULT); ::UpdateWindow(hWnd);
// Main message loop. MSG msg; while (::GetMessage(&msg, hWnd, 0, 0) > 0) ::DispatchMessage(&msg);
// Unregister window class, freeing the memory that was // previously allocated for this window. ::UnregisterClass(wcex.lpszClassName, hInstance);
return (int)msg.wParam; }
File resource2.h :
ifndef HEADER_RESOURCE__INCLUDED
define HEADER_RESOURCE__INCLUDED
define IDI_ICON_1 102
define IDI_ICON_2 103
endif
File main.rc :
if defined(_WIN32) || defined(_WIN64)
include
include
include "resource2.h"
LANGUAGE LANG_FRENCH, SUBLANG_FRENCH
pragma code_page(1252)
//////////////////////////////////////////////////////////////////////////// // // Icon //
// Icon with lowest ID value placed first to ensure application icon // remains consistent on all systems. IDI_ICON_1 ICON "OpenGL.ico" IDI_ICON_2 ICON "OpenGL.ico"
endif
File to generate application with MinGW64 "generate_mingw64.bat" :
set PATHSAV=%PATH% set PATH=C:\mingw64\bin;%PATH% windres main.rc -O coff -o main.res g++ -o main.exe main.cpp main.res -Wl,-subsystem,windows -municode set PATH=%PATHSAV%
File to generate application with Open WATCOM V2 "generate_watcom.bat" :
set PATHSAV=%PATH% set PATH=C:\WATCOM\binnt;%PATH% wrc main.rc -r -bt=nt -iC:\WATCOM\h\nt -iC:\WATCOM\h -fomain.res wpp386 -bg -bt=nt main.cpp -IC:\WATCOM\h\nt -IC:\WATCOM\h wlink option quiet system nt_win LIBP C:\WATCOM\lib386\nt;C:\WATCOM\lib386 file main.obj option resource=main.res name main.exe library user32,kernel32 set PATH=%PATHSAV%
This two generations success, but only with GCC executable is "see" in Explorer with icon, not with OW 2.0.
Bug ?
Thank's.