search

open-wc / api-viewer-element

API documentation and live playground for Web Components. Based on Custom Elements Manifest format
https://api-viewer.open-wc.org
MIT License
268 stars 25 forks source link

refactor: move customElements.whenDefined to willUpdate #167

Closed web-padawan closed 1 year ago

web-padawan commented 1 year ago

Description

Refactored logic to fix the following error reported by the latest version of eslint-plugin-lit:

packages/api-demo/src/layout.ts
  78:7  error  Members of `this` should not be assigned to in the render method. It is likely you should do this elsewhere instead (e.g. in `updated`)  lit/no-this-assign-in-render
netlify[bot] commented 1 year ago

Deploy Preview for api-viewer ready!

Name Link
Latest commit aba0093a7c60d94ba06d4674639e2442c3ef0bb4
Latest deploy log https://app.netlify.com/sites/api-viewer/deploys/6394e5b735567c0009df388b
Deploy Preview https://deploy-preview-167--api-viewer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.