search

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
227 stars 37 forks source link

feat: third parties #142

Closed thepassle closed 1 year ago

thepassle commented 2 years ago

Todo

closes https://github.com/open-wc/custom-elements-manifest/issues/121 closes https://github.com/open-wc/custom-elements-manifest/issues/130 closes https://github.com/open-wc/custom-elements-manifest/issues/123

netlify[bot] commented 2 years ago

✔️ Deploy Preview for custom-elements-manifest-analyzer ready!

🔨 Explore the source changes: 9210ee298f17709858136ac99618bafb8144a59d

🔍 Inspect the deploy log: https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/61a693528eb9a80007a8fd1f

😎 Browse the preview: https://deploy-preview-142--custom-elements-manifest-analyzer.netlify.app

Westbrook commented 2 years ago

Hey @thepassle how is this PR coming? Would love to see the --packagejson option land, so if there's anything I can do to help with that, please let me know!

thepassle commented 2 years ago

Still intend on finishing this, but havent had much time recently to work on it.

Westbrook commented 2 years ago

Would you be happy/indifferent/annoyed if I reached in for the package.json change and submitted a stand alone PR?

thepassle commented 2 years ago

The easiest would probably be to finish this PR then, its really not far off. Just need to filter out third party modules at the end and test that everything works as expected

Westbrook commented 2 years ago

I can dive in and see if I fully understand what that means and get back to you. Would you have minute to catch this branch up to master today or tomorrow to make that easier?

thepassle commented 2 years ago

Done

So currently we pick up third party CEMs and we add a isDependency property to them so that we can remove them at the end. That still needs to be done.

And otherwise we just need to make sure all the functionality works as expected (e.g. if i extend a class from a third party, is the inheritance output correctly in the CEM? Etc)

I think thats it

Westbrook commented 2 years ago

Does that mean that these to dos are already done?

I'll start digging in tomorrow!

thepassle commented 2 years ago

Merge found cems is done, logging could be made a bit nicer actually still

thepassle commented 1 year ago

this was done in https://github.com/open-wc/custom-elements-manifest/pull/173