Open tlouisse opened 2 years ago
Name | Link |
---|---|
Latest commit | 181826d71b221db1bcc028efb88d2fe04b383825 |
Latest deploy log | https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/62722e72067d3d00089ce7ae |
Deploy Preview | https://deploy-preview-170--custom-elements-manifest-analyzer.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Did you also want to actually apply the function anywhere in this PR? Or are you planning that for a separate PR?
Did you also want to actually apply the function anywhere in this PR? Or are you planning that for a separate PR?
We can work around it atm, so I added .skip
for now. But maybe in the future I want to do it in a separate PR :).
@dakmor and me just had a look, and it should be possible to get all type info from the TS AST.
(Type info is found on the right)
Hi,
When running the tool on our Lion components (LionInputAmount) in particular, we found out that
handleJsDoc
does not recognize object params built from multiple@param
tags.For instance:
Is expected to return the following parameters:
(currently it returns two params).
I created a failing unit test for the scenario above (it's skipped on purpose now, so this can be merged if wanted).
@thepassle since there were only integration tests for the analyzer package so far, feel free to say if you don't agree with the approach or want to do this in a different way :)